Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setup implementation #4

Merged
merged 2 commits into from
Feb 20, 2019
Merged

Conversation

vasco-santos
Copy link
Member

@vasco-santos vasco-santos commented Feb 11, 2019

Created the setup for running js-libp2p / go-libp2p daemons and an associated daemon client, in order to allow the interop tests to focus on its purpose, instead of building the setup each time.

This PR also contains interop tests for connect:

  • js-libp2p-daemon node connect to go-libp2p-daemon
  • go-libp2p-daemon node connect to js-libp2p-daemon (skipped for now, as I am facing an issue on this).

Needs:

@ghost ghost assigned vasco-santos Feb 11, 2019
@ghost ghost added the status/in-progress In progress label Feb 11, 2019
@vasco-santos vasco-santos force-pushed the feat/initial-implementation branch from 3cf1a17 to 2944a12 Compare February 11, 2019 15:22
@vasco-santos
Copy link
Member Author

@jacobheun would be awesome if you have a look at this setup before I continue with the tests.

@vasco-santos vasco-santos force-pushed the feat/initial-implementation branch 20 times, most recently from 1bed75c to d7c5fcc Compare February 18, 2019 16:34
@vasco-santos vasco-santos force-pushed the feat/initial-implementation branch from d7c5fcc to 86e947d Compare February 18, 2019 18:00
@vasco-santos vasco-santos mentioned this pull request Feb 19, 2019
3 tasks
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor feedback, overall this is looking good!

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/daemon.js Show resolved Hide resolved
src/daemon.js Show resolved Hide resolved
src/daemon.js Show resolved Hide resolved
src/utils.js Outdated Show resolved Hide resolved
test/connect/README.md Outdated Show resolved Hide resolved
test/connect/go2go.js Outdated Show resolved Hide resolved
test/connect/go2go.js Outdated Show resolved Hide resolved
test/connect/js2js.js Outdated Show resolved Hide resolved
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

@vasco-santos vasco-santos merged commit e3364bf into master Feb 20, 2019
@ghost ghost removed the status/in-progress In progress label Feb 20, 2019
@vasco-santos vasco-santos deleted the feat/initial-implementation branch February 20, 2019 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants